[SYCL][Driver] Fix suggested target triple in the warning message #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning message emitted for deprecated target triple includes suggested target triple to be used instead of deprecated one. Currently it prints only architecture component of the target triple, which works only for SPIR target architecture. Non-SPIR targets may support multiple vendor/OS components, so users are expected to specify the full triple. This patch fixes the warning message and suggests all components set before deprecated `sycldevice` environment component if they are not "unknown" (which is default and can be omitted).
bader
added
cuda
bader
requested review from
AGindinson,
hchilama and
mdtoguchi
as code owners
mdtoguchi
reviewed
Sep 2, 2021
bader
referenced
this pull request
Sep 3, 2021
Today DPC++ compiler requires users to set "sycldevice" target triple component to separate SYCL compilation mode for SPIR target from other compilation mode (e.g. OpenCL). Triple environment component is not intended to be used in such context and this patch removes `sycldevice`. This patch also preserves backward compatibility with binaries built using old versions of the compiler, which enforced `sycldevice` environment component of the target triple. It's provided by `clang-offload-bundler` tool, which now implicitly looks for the additional SYCL offload kind bundle with a "legacy" triple. A driver warning was added to let users know that `sycldevice` environment component is ignored now.
mdtoguchi
approved these changes
Sep 7, 2021
DoyleLi
pushed a commit
to DoyleLi/intel_llvm
that referenced
this pull request
Sep 13, 2021
…tel#4475) The warning message emitted for deprecated target triple includes suggested target triple to be used instead of deprecated one. Currently it prints only architecture component of the target triple, which works only for SPIR target architecture. Non-SPIR targets may support multiple vendor/OS components, so users are expected to specify the full triple. This patch fixes the warning message and suggests all components set before deprecated `sycldevice` environment component if they are not "unknown" (which is default and can be omitted).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning message emitted for deprecated target triple includes
suggested target triple to be used instead of deprecated one. Currently
it prints only architecture component of the target triple, which works
only for SPIR target architecture. Non-SPIR targets may support multiple
vendor/OS components, so users are expected to specify the full triple.
This patch fixes the warning message and suggests all components set
before deprecated
sycldeviceenvironment component if they are not"unknown" (which is default and can be omitted).