Add another parameter value for the pipelined kernel interface property #6966
Conversation
| @@ -287,4 +295,4 @@ q.single_task(KernelFunctor{a, b, c}).wait(); | |||
| |======================================== | |||
| |Rev|Date|Author|Changes | |||
| |1|2022-03-01|Abhishek Tiwari|*Initial public working draft* | |||
There was a problem hiding this comment.
Not needed as that was the date when the initial spec was put for review.
| When the parameter is set to `0`, the compiler will not pipeline kernel | ||
| invocations. | ||
|
|
||
| If the `pipelined` property is not specified, the default behavior is | ||
| equivalent to a combination of the property parameter values listed above, but | ||
| the choice is implementation defined. | ||
| the choice is implementation defined. Similarly, if the property parameter is | ||
| not specified, the default value is implementation defined. |
There was a problem hiding this comment.
If the parameter is not defined I think we should say its default value is -1. -1 already means it's up to the compiler to determine II so I don't think we need the extra layer of implementation defined indirection.
sycl/doc/extensions/proposed/sycl_ext_intel_fpga_kernel_interface_properties.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_intel_fpga_kernel_interface_properties.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Garvey <joseph.garvey@intel.com>
Co-authored-by: Joe Garvey <joseph.garvey@intel.com>
|
@intel/dpcpp-specification-reviewers Please review and merge this one, thank you! |
| When the parameter is set to `0`, the compiler will not pipeline kernel | ||
| invocations. | ||
|
|
||
| If the `pipelined` property is not specified, the default behavior is | ||
| equivalent to a combination of the property parameter values listed above, but | ||
| the choice is implementation defined. | ||
|
|
||
| If the property parameter is not specified, the default value is `-1`. |
There was a problem hiding this comment.
What happens if N < -1? If it isn't a valid value, could you please add a note somewhere in this section specifying that valid values are N >= -1?
There was a problem hiding this comment.
Thank you for the quick review. Updated to state valid values are >= -1.
Addressed. Please merge when possible. Thank you! :) |
The
pipelinedkernel property is defined to control the pipelining behavior. This PR updates the extension to say how a value of-1can be used to enforce a particular pipelining behavior.