Fix xmethods for gdb #7009
Merged
Fix xmethods for gdb #7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As extensively discussed here https://sourceware.org/bugzilla/show_bug.cgi?id=28480 the access of "_M_head_impl" for unique_ptr compiled with newer versions of libstdc++ might be ambiguous. We change the xmethods script to instead evaluate the unique_ptr's get() method which resolves this.
An earlier commit deprecated the use of sycl::access::target::local and instead introduced the template class sycl::local_accessor. We have to match the new class' name in our xmethods script, too. The handling is the same as for the sycl::accessor.
GDB needs both, the const and non-const versions of the helper methods for its pretty-printers. This commit adds the const versions to the GDBMethodsAnchor.
|
@barisaktemur FYI. You may want to have a look. I only tested this by changing a private version of the xmethods script and running all tests on my machine locally. |
romanovvlad
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a few issues in the GDB xmethods scripts. This PR fixes them.