[SYCL] Implement SYCL 2020 default async_handler behavior #7162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL 2020 specifies that if no async_handler is given to either the queue nor the context a default async_handler will be used. This default handler must report the problems reported and call `std::terminate` or similar. This commit adds an implementation of the default async_handler. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
commented
Oct 26, 2022
| { | ||
| std::lock_guard<std::mutex> Lock(MMutex); | ||
| MExceptions.PushBack(std::current_exception()); | ||
| } |
There was a problem hiding this comment.
This behavior was incorrect. Synchronous errors during submit should not be reported asynchronously.
|
/verify with intel/llvm-test-suite#1351 |
1 similar comment
|
/verify with intel/llvm-test-suite#1351 |
|
@dm-vodopyanov / @intel/llvm-reviewers-runtime - Friendly ping. |
romanovvlad
reviewed
Nov 2, 2022
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1351 |
dm-vodopyanov
approved these changes
Nov 2, 2022
|
Failure on Windows is unrelated. SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp |
steffenlarsen
added a commit
to intel/llvm-test-suite
that referenced
this pull request
Nov 9, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL 2020 specifies that if no async_handler is given to either the queue nor the context a default async_handler will be used. This default handler must report the problems reported and call
std::terminateor similar. This commit adds an implementation of the default async_handler.