[SYCL][L0] Skip uninitialized buffer migration copy #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
againull
approved these changes
Oct 24, 2022
smaslov-intel
commented
Oct 24, 2022
Comment on lines
+8866
to
+8867
| if (ZeHandleSrc == ZeHandle) | ||
| NeedCopy = false; |
There was a problem hiding this comment.
Note, that in the case that I was fixing (single root-device context with multiple sub-devices in it) this alone is probably enough, but I thought that handling LastDeviceWithValidAllocation == nullptr is also a good idea and it avoids many copies by itself even without this check
|
Sergey, there is one failure which may be related to the changes: Failed Tests (1): |
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Yeah, it is. I've added small additional fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com