[SYCL] Enable sub group masks for 64 bit subgroups #7491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2022
dm-vodopyanov
approved these changes
Nov 23, 2022
npmiller
force-pushed
the
fix-64-ballot
branch
from
6ce9a4b
to
7bf91ea
Compare
|
@romanovvlad, ping. |
romanovvlad
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is adding group ballot support for HIP (based on initial work from @abagusetty on #6734 ), but also extending the sub-group mask implementation to support 64 bit masks, as a lot of AMD GPUs use 64 bit wavefronts.
Related to issue: #6718