[SYCL][Level Zero] Implement sycl_ext_intel_queue_index extension #7599
Conversation
|
Will you add any tests to llvm-test-suite? |
Sorry, I just saw that you added tests in intel/llvm-test-suite#1425 |
|
/verify with intel/llvm-test-suite#1425 |
|
@smaslov-intel I've added oneapi-src/unified-runtime#120 to track this. |
|
/verify with intel/llvm-test-suite#1425 |
|
The testing in "verify with" is clean. |
|
@intel/dpcpp-esimd-reviewers can you please review this today? |
| assert(Properties[0] == PI_QUEUE_FLAGS); | ||
| pi_queue_properties Flags = Properties[1]; | ||
| // Extra data isn't supported yet. | ||
| assert(Properties[2] == 0); |
There was a problem hiding this comment.
Correct me if I'm wrong, but this assert can be triggered by the user. Would it be better to return PI_ERROR_INVALID_OPERATION instead to make it a recoverable error rather than a failed assert? Note that the call should be changed to call rather than call_nocheck.
There was a problem hiding this comment.
Discussed offline. This will be done in a follow-up patch.
|
Failures in verifications are unrelated and have been reported separately. Merging this. |
The feature needs to pass extra data to
piQueueCreatewhich isimpossible with the current interface. As such, and because of the
current ABI freeze, a new
piQueueCreateExinterface has been addedaccepting
pi_queue_properties *Properties(similarly to otherinterfaces allowing optional/additional data) with the plan to retire
the old one at the next ABI break window.
Extension spec: #7520