[SYCL][DOC] Remove size, get_wait_list from queue #7612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `queue::size` and `queue::get_wait_list` member functions from the proposed "sycl_ext_oneapi_queue_status_query" extension.f After some implementation experience, we learned that these functions cause some unexpected overhead. Since we only have a strong use case for `queue::empty`, we decided to remove these others. Also rename the extension to match the new scope.
Pennycook
approved these changes
Dec 2, 2022
|
I just noticed a typo in the commit ("SYTCL"); I think that can be fixed when it gets merged. |
gmlueck
changed the title
I fixed the title of this PR. I think that's what get's used for the squashed merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
queue::sizeandqueue::get_wait_listmember functions from the proposed "sycl_ext_oneapi_queue_status_query" extension.f After some implementation experience, we learned that these functions cause some unexpected overhead. Since we only have a strong use case forqueue::empty, we decided to remove these others.Also rename the extension to match the new scope.