[NFC][SYCL] Switch to std:: equivalents for utilities in stl_type_traits.hpp #7668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
approved these changes
Dec 7, 2022
|
|
||
| // Custom type traits. | ||
| // FIXME: Those doesn't seem to be a part of any published/future C++ standard | ||
| // so should probably be moved to a different place. |
There was a problem hiding this comment.
We probably can drop stl_ prefix from the file name to avoid confusion. What do you think?
There was a problem hiding this comment.
We have detail/type_traits.hpp already that has lots of custom stuff (and remove_pointer that seems to behave differently than std:: version). I think that the best would be to move this code to detail/type_traits.hpp.
As for this file, I'm planning to add C++20's remove_cvref_t here.
There was a problem hiding this comment.
Following up on the previous comment - sycl::detail::remove_pointer difference comes from sycl::multi_ptr support, I think.
known, #7634. |
v-klochkov
approved these changes
Dec 7, 2022
are known - #7634. @intel/llvm-gatekeepers , this PR is ready. |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 14, 2022
…type_traits.hpp (intel#7668)" This reverts commit f4fc927. We found issues when trying to build the project on RHEL7 systems that we need in our OS support matrix.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Apr 21, 2023
…its.hpp Re-commits intel#7628 and intel#7668 that were previously reverted due to build issues on RHEL systems. The issues were fixed by introducing `SYCL_LIBDEVICE_GCC_TOOLCHAIN` cmake configuration option in intel#7771.
againull
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.