Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Media Common] SW swizzling regression fix for Gen8/9/10 #1589

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

MicroYY
Copy link
Contributor

@MicroYY MicroYY commented Jan 9, 2023

Signed-off-by: Jay Yang jay.yang@intel.com
Fix: #1590

Add sw swizzling sku for Gen8/9/10, without which there will be perf
drop because mos_gem_bo_map_unsynchronized is called.

@MicroYY MicroYY changed the title [Media Common] SW swizzling support for Gen9 [Media Common] SW swizzling support for Gen8/9/10 Jan 9, 2023
@MicroYY MicroYY changed the title [Media Common] SW swizzling support for Gen8/9/10 [Media Common] SW swizzling regression fix for Gen8/9/10 Jan 9, 2023
@@ -540,6 +546,8 @@ static bool InitGlkMediaSku(struct GfxDeviceInfo *devInfo,

MEDIA_WR_SKU(skuTable, FtrHDR, 1);

MEDIA_WR_SKU(skuTable, FtrUseSwSwizzling, 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLK is small core , is using map_gtt, when this WA take effect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used before mapping

else if ((surface->pMediaCtx->m_useSwSwizzling) && !(flag & MOS_LOCKFLAG_NO_SWIZZLE))

Signed-off-by: Jay Yang <jay.yang@intel.com>

Add sw swizzling sku for Gen8/9/10, without which there will be perf
drop because mos_gem_bo_map_unsynchronized is called.
@XinfengZhang XinfengZhang added the verifying PR: fix ready and verifying with build/test label Jan 13, 2023
@intel-mediadev intel-mediadev merged commit 4c2547e into intel:master Jan 13, 2023
@MicroYY MicroYY mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verifying PR: fix ready and verifying with build/test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression related to vaGetImage()
3 participants