Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Add a clang build. #240

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

ossama-othman
Copy link
Member

No description provided.

@ossama-othman ossama-othman added the enhancement New feature or request label Jun 24, 2022
@ossama-othman ossama-othman self-assigned this Jun 24, 2022
@ossama-othman
Copy link
Member Author

I added a clang build because I ran into an unexpected compile-time error when building mptcpd with clang 14. See #239.

@coveralls
Copy link

coveralls commented Jun 24, 2022

Pull Request Test Coverage Report for Build 2557354611

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.609%

Totals Coverage Status
Change from base Build 2557225052: 0.0%
Covered Lines: 1149
Relevant Lines: 1865

💛 - Coveralls

Copy link
Member

@mjmartineau mjmartineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Does it make sense to also build mptcpd with clang?

@ossama-othman
Copy link
Member Author

ossama-othman commented Jun 27, 2022

Looks good to me. Does it make sense to also build mptcpd with clang?

Only mptcpd is built with clang. The ./configure CC=... is for mptcpd. ELL is built with whatever the compiler the configure script picks, gcc in this case. Commit e1f8329 causes ELL to built with clang along with mptcpd.

@ossama-othman ossama-othman merged commit f6c2464 into multipath-tcp:master Jun 27, 2022
@ossama-othman ossama-othman deleted the clang-build branch June 27, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants