Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markup for warnings #736

Closed
pohly opened this issue Sep 18, 2020 · 5 comments
Closed

markup for warnings #736

pohly opened this issue Sep 18, 2020 · 5 comments
Assignees
Labels
0.8 needs to be fixed in 0.8.x

Comments

@pohly
Copy link
Contributor

pohly commented Sep 18, 2020

It would be useful to highlight paragraphs as info or warning (as in github/markup#887).

The proposal with embedded ‼️ in a table was tried, but didn't work with Sphinx (:bangbang: as rendered literally, #715 (comment)):

### Metrics support

:bangbang: | Metric support is an alpha feature. What data is provided may change.
:---: | :---

=>

Metrics support

‼️ Metric support is an alpha feature. What data is provided may change.
@pohly
Copy link
Contributor Author

pohly commented Sep 18, 2020

@intelkevinputnam : do you have an idea how to do this?

@pohly pohly mentioned this issue Sep 18, 2020
2 tasks
@intelkevinputnam
Copy link
Contributor

I don't know of a way to make special characters work for both GitHub and Sphinx. Rather than the emoji, though, you could use **WARNING** or **NOTE**, or **!!**:

!! Metric support is an alpha feature. What data is provided may change.

restructuredText has "Admonitions" which can be warnings, notes, etc. Markdown doesn't have them out of the box, though. Myst flavored markdown implements reST admonitions with this syntax:

```{admonition} Warning
This is Beta software.
```

In GitHub they look like this:

This is Beta software.

I could probably implement something that works like this in a couple of days. They work OK in GitHub (the notes would appear in code blocks) and would be proper "Notes" and "Warnings" in Sphinx output.

@pohly
Copy link
Contributor Author

pohly commented Sep 21, 2020

I think **WARNING** and **NOTE** inside a table are good enough, no need to implement any custom syntax support in the publishing pipeline.

@avalluri : agreed?

@avalluri
Copy link
Contributor

@avalluri : agreed?

Yes.

@pohly pohly added the 0.8 needs to be fixed in 0.8.x label Sep 23, 2020
@pohly pohly self-assigned this Sep 23, 2020
@pohly
Copy link
Contributor Author

pohly commented Sep 30, 2020

This renders poorly in the docsite: https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/job/pmem-csi/job/PR-760/Doc_20Site/docs/install.html#metrics-support

Let's stick with the current approach (**WARNING:** or **NOTE:** at the beginning of a paragraph).

@pohly pohly closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.8 needs to be fixed in 0.8.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants