metrics support #715
Merged
metrics support #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
force-pushed
the
metrics-enhancements
branch
from
aa94b63
to
833440c
Compare
|
Force-pushed to trigger CI testing. |
pohly
force-pushed
the
metrics-enhancements
branch
2 times, most recently
from
bc7a4e5
to
f545758
Compare
pohly
force-pushed
the
metrics-enhancements
branch
from
f545758
to
9028e12
Compare
pohly
force-pushed
the
metrics-enhancements
branch
from
9028e12
to
ed78869
Compare
Those date back to the very beginning of the project and were used as a reminder for content that might be missing. We have added everything over time, so they no longer serve any real purpose.
pohly
force-pushed
the
metrics-enhancements
branch
2 times, most recently
from
8c34c9f
to
8cf3d52
Compare
|
@avalluri this PR is ready, I finished all pending TODOs. |
pohly
commented
Sep 16, 2020
docs/install.md
Outdated
| <!-- FILL TEMPLATE: | ||
| ### Metrics support | ||
|
|
||
| :bangbang: | Metric support is an alpha feature. What data is provided may change. |
There was a problem hiding this comment.
This works on GitHub (not surpising, I got this from github/markup#887) but not in Sphinx (just shows :bangbang:):
@intelkevinputnam : do you have a suggestion how we can mark up warnings in our documentation?
There was a problem hiding this comment.
I'll merge without this warning and instead moved it into an issue: #736
The Prometheus integration uses the approach from helm/charts#22899: - HTTP for metrics endpoints - container ports tell Prometheus which containers to scrape and how CSI call counts are the same as in the sidecars. This enables correlating statistics and ensures that also node-local operations are captured; kubelet doesn't seem to be instrumented. Internal communication is instrumented the same way. PMEM usage statistics are recorded by querying the active device manager each time the metrics data gets scraped. The metrics support is enabled unconditionally in the operator and all pre-generated deployment files and use plain HTTP for the sake of simplicity. This is based on the rationale that the data itself is not sensitive and should always be readily available if desired.
pohly
force-pushed
the
metrics-enhancements
branch
from
8cf3d52
to
ef274da
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prometheus integration uses the approach from
helm/charts#22899:
- HTTP for metrics endpoints
- container ports tell Prometheus which containers to scrape
and how
CSI call counts are the same as in the sidecars. This enables
correlating statistics and ensures that also node-local operations are
captured; kubelet doesn't seem to be instrumented.
Internal communication is instrumented the same way.
PMEM usage statistics are recording by querying the device manager
each time the metrics data gets scraped.
The metrics support is enabled unconditionally in the operator and all
pre-generated deployment files and use plain HTTP for the sake of
simplicity. This is based on the rationale that the data itself is
not sensitive and should always be readily available if desired.
TODO: