Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default behavior of Interface.connectIO causes multiple input/output module connections per port #38

Closed
mkorbel1 opened this issue Nov 4, 2021 · 0 comments · Fixed by #58
Closed

Default behavior of Interface.connectIO causes multiple input/output module connections per port #38

mkorbel1 opened this issue Nov 4, 2021 · 0 comments · Fixed by #58
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mkorbel1
Copy link
Contributor

mkorbel1 commented Nov 4, 2021

Describe the bug
Default behavior for Interface.connectIO passes inputTags and outputTags as optionally null directly to getPorts , which then returns all ports.

To Reproduce
Call connectIO with no inputTags nor outputTags on an Interface which has at least one port.

Expected behavior
If no tags are provided, it should not connect anything. Maybe should throw an exception if neither is provided?

Actual behavior
Exception "Already defined a port with name..."
@mkorbel1 mkorbel1 added bug Something isn't working good first issue Good for newcomers labels Nov 4, 2021
mkorbel1 added a commit to mkorbel1/rohd that referenced this issue Nov 30, 2021
@mkorbel1
fix intel#38 connectio bug on interface
3b34c80
@mkorbel1 mkorbel1 mentioned this issue Nov 30, 2021
Merged
mkorbel1 added a commit that referenced this issue Nov 30, 2021
@mkorbel1
Fix #38: Interface.connectIO bug with no tags specified (#58)
78e01a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #38: Interface.connectIO bug with no tags specified mkorbel1/rohd
1 participant
@mkorbel1