Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various features and testing for Logic and LogicValue #121

Merged
merged 10 commits into from
May 5, 2022

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented May 5, 2022

Description & Motivation

Further improving the usability of and consistency between Logic and LogicValue. Includes:

  • getRange on Logic
  • zeroExtend, and signExtend on Logic and LogicValue, plus extend on `LogicValue.
  • withSet for LogicValue and Logic
  • reversed on Logic
  • slice on LogicValue
  • Reverse slicing on both Logic and LogicValue
  • Made IfBlock a little more flexible
  • Improved documentation and README around these features
  • Added a script to generate line coverage

Related Issue(s)

Close #113
Improve on #91
Close #117
Close #101
Close #83
Fix #122

Testing

Passing existing tests and added a bunch more tests.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Yes, documentation updated

@mkorbel1 mkorbel1 marked this pull request as draft May 5, 2022 03:35
@mkorbel1 mkorbel1 marked this pull request as ready for review May 5, 2022 16:07
@mkorbel1 mkorbel1 merged commit fdee0cb into intel:main May 5, 2022
@mkorbel1 mkorbel1 deleted the extend branch May 5, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment