Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add modulo support #136

Merged
merged 4 commits into from
Jul 6, 2022
Merged

add modulo support #136

merged 4 commits into from
Jul 6, 2022

Conversation

chaparalas
Copy link
Contributor

Description & Motivation

Add modulo support

Related Issue(s)

Testing

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

NO

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Yes

mkorbel1
mkorbel1 requested changes Jul 6, 2022
View reviewed changes
test/logic_value_test.dart Show resolved Hide resolved
lib/src/logic.dart Show resolved Hide resolved
@mkorbel1 mkorbel1 linked an issue Jul 6, 2022 that may be closed by this pull request
Implement modulus operator % #16
Closed
@chaparalas chaparalas requested a review from mkorbel1 July 6, 2022 16:13
mkorbel1
mkorbel1 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution!

@mkorbel1 mkorbel1 merged commit ec33e9e into intel:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement modulus operator %
2 participants
@chaparalas @mkorbel1