Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves issue #138 #190

Merged
merged 33 commits into from
Nov 2, 2022
Merged

resolves issue #138 #190

merged 33 commits into from
Nov 2, 2022

Conversation

quekyj
Copy link
Contributor

@quekyj quekyj commented Oct 24, 2022

Description & Motivation

Fix bug of the definition name is not sanitized on Module class extend.

Related Issue(s)

Issue #138

Testing

  • dart test passed on local.
  • Add a new unit test to test for the sanitization on the unclean variable name

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@quekyj quekyj changed the title Resolves Issue #138 resolves Issue #138 Oct 24, 2022
@quekyj quekyj changed the title resolves Issue #138 resolves #138 Oct 24, 2022
@quekyj quekyj changed the title resolves #138 resolves issue #138 Oct 24, 2022
mkorbel1
mkorbel1 requested changes Oct 25, 2022
View reviewed changes
lib/src/module.dart Outdated Show resolved Hide resolved
lib/src/exception/name_exception.dart Outdated Show resolved Hide resolved
lib/src/exception/name_exception.dart Outdated Show resolved Hide resolved
test/definition_name_test.dart Outdated Show resolved Hide resolved
test/logic_name_test.dart Outdated Show resolved Hide resolved
@quekyj quekyj requested a review from mkorbel1 October 26, 2022 04:47
mkorbel1
mkorbel1 requested changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this all looks good! Just a few more clean-up things.

lib/src/exceptions/name_exceptions.dart Outdated Show resolved Hide resolved
lib/src/exceptions/exceptions.dart Outdated Show resolved Hide resolved
test/definition_name_test.dart Show resolved Hide resolved
test/logic_name_test.dart Show resolved Hide resolved
lib/src/module.dart Show resolved Hide resolved
lib/src/module.dart Outdated Show resolved Hide resolved
test/definition_name_test.dart Outdated Show resolved Hide resolved
@quekyj quekyj requested a review from mkorbel1 October 30, 2022 10:33
mkorbel1
mkorbel1 reviewed Nov 1, 2022
View reviewed changes
lib/src/module.dart Outdated Show resolved Hide resolved
@quekyj quekyj requested a review from mkorbel1 November 1, 2022 02:09
@mkorbel1 mkorbel1 merged commit 11c3209 into intel:main Nov 2, 2022
@mkorbel1 mkorbel1 linked an issue Dec 15, 2022 that may be closed by this pull request
Custom definition names of Modules are not sanitized #138
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom definition names of Modules are not sanitized
2 participants
@quekyj @mkorbel1