[Issue-112] Automatically extract rohd version from pubspec to add into generated sv #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quekyj
commented
Nov 17, 2022
quekyj
commented
Nov 17, 2022
mkorbel1
reviewed
Nov 23, 2022
|
If we create a (pre-)release script, a couple things it can do:
|
|
Write a unit test to check for |
|
Omit the hash part, too complicated to implement. |
mkorbel1
requested changes
Nov 27, 2022
mkorbel1
requested changes
Nov 30, 2022
mkorbel1
requested changes
Dec 1, 2022
quekyj
added a commit
to quekyj/rohd
that referenced
this pull request
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
It would be nice if the generated outputs (e.g. SystemVerilog, waveform dumps) had a guaranteed accurate version number of ROHD that generated them. A version number (from pubspec.yaml) would be good, but even better would be to also include a git hash, so it can be determined exactly what generated the code.
Related Issue(s)
issue #112
Testing
Add test to expect the rohd version and git commit are available in the generated system verilog code generation.
Backwards-compatibility
no.
Documentation
Ya, added to each of the file created.