Initial implementation of more robust tests for LogicValue and LogicV… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues. Still some issues to resolve - see comments in file.
|
Committing early so @mkorbel1 can review some of the outstanding issues (listed as TODOs at the top of the file). |
mkorbel1
reviewed
Sep 27, 2021
mkorbel1
reviewed
Sep 27, 2021
|
In general, note that there's three separate implementations for |
… are still causing failures and those have been left disabled.
…or Big and Filled.
… Coverage isn't complete but it's a good start. Next set of tests should be around the border between Big and Small.
* Add LogicValue.ofBool helper This is useful for creating a logicvalue from a boolean without writing its simple implementation over and over. Also added tests to cover this new functionality. * LogicValue.fromBool, Logicvalues.fromBool - Rename LogicValue.ofBool() to .fromBool - Add LogicValues.ofBool() - Update tests
… are still causing failures and those have been left disabled.
…or Big and Filled.
…o linting passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alues. Still some issues to resolve - see comments in file.
Description & Motivation
Related Issue(s)
Testing
Backwards-compatibility
Documentation