Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to check sanitized names #258

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

aherrera97intl
Copy link
Contributor

Description & Motivation

Added function to validate sanitizer

Related Issue(s)

#152

Testing

Call sanitizer to check on signal given

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 linked an issue Feb 7, 2023 that may be closed by this pull request
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chykon
Copy link
Contributor

chykon commented Feb 7, 2023

Maybe the Z value should also be added to the test string?

@aherrera97intl
Copy link
Contributor Author

Done, added z to signal check

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work!

@mkorbel1 mkorbel1 merged commit 5ea9512 into intel:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consts where val is a LogicValue have unsanitary names
3 participants