Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update chapter 2 bootcamp #310

Merged
merged 91 commits into from
Apr 3, 2023
Merged

update chapter 2 bootcamp #310

merged 91 commits into from
Apr 3, 2023

Conversation

quekyj
Copy link
Contributor

@quekyj quekyj commented Mar 13, 2023

Description & Motivation

Update chapter 2 bootcamp by adding examples and fix assign statement does not show up.

Related Issue(s)

None

Testing

None

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@quekyj
Copy link
Contributor Author

quekyj commented Mar 16, 2023

Why is this a dead link in Github action?

FILE: ./CONTRIBUTING.md
[✖] https://dart.dev/guides/language/effective-dart

22 links checked.

ERROR: 1 dead links found!
[✖] https://dart.dev/guides/language/effective-dart → Status: 0

@chykon
Copy link
Contributor

chykon commented Mar 16, 2023

Why is this a dead link in Github action?

You can try restarting CI after a while (maybe the site was down or DDoS protection worked), or add it to the ignore list (https://github.com/intel/rohd/blob/main/.github/configs/mlc_config.json) as we are sure this is a false positive.

When adding to the ignore list, it is advisable to adhere to the pattern:

  • first ^
  • then LINK
  • at the end of $

We use regular expression syntax to mark the start (^) and end ($) of text, which allows us to ignore only the address that exactly matches the specified one, and not any addresses that contain such a substring. An example is already on the ignore list itself.

@quekyj
Copy link
Contributor Author

quekyj commented Mar 20, 2023

You can try restarting CI after a while (maybe the site was down or DDoS protection worked), or add it to the ignore list (https://github.com/intel/rohd/blob/main/.github/configs/mlc_config.json) as we are sure this is a false positive.

Do you think the whitelist should be added to this pull request or better separate it into other pull request instead?

@chykon
Copy link
Contributor

chykon commented Mar 20, 2023

It would probably be worth making the changes related to the ignore settings in a separate PR, but I personally did not think about it until you rightly pointed it out. It's probably best to check with the maintainer of the repository.

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkorbel1
Copy link
Contributor

I think you need to pull master to fix the failing test

@mkorbel1 mkorbel1 merged commit b8dbebd into intel:main Apr 3, 2023
@quekyj quekyj deleted the chapter-2-bootcamp branch August 8, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants