Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to benchmark files #325

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

chykon
Copy link
Contributor

@chykon chykon commented Mar 20, 2023

Description & Motivation

It is proposed to make small changes to the benchmark files:

  • Rename BENCHMARKING.md to README.md so that the information is immediately displayed when going to the benchmark directory on GitHub
  • Make the order of the fields (license, date, authorship) at the bottom of README.md match the order of the header template used in code files; add new line breaks
  • Change benchmark files a bit (update headers, add missing final, remove empty functions)

Related Issue(s)

No.

Testing

Not required - the functionality does not change.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

The benchmark information file (README.md) will change slightly.

@chykon
Copy link
Contributor Author

chykon commented Mar 21, 2023

CI ended with an error due to #324.

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, thanks!

@mkorbel1 mkorbel1 merged commit 15404c5 into intel:main Mar 30, 2023
@chykon chykon deleted the benchmark-improvements branch March 30, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants