Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #148: Implemented neq #350

Merged
merged 4 commits into from
May 1, 2023

Conversation

Sanchit-kumar
Copy link
Contributor

Description & Motivation

Equality checks with eq are simple, but need to write ~...eq for not-equal-to. It would be nice to be able to do not-equal-to using neq.

Testing

Updated the test/comparison_test.dart file for neq w.r.t already used values for the other supported operations.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Yes. I have updated both README.md and /doc/tutorials/chapter_2/00_basic_logic.md for neq operation.

@mkorbel1 mkorbel1 mentioned this pull request Apr 28, 2023
@mkorbel1 mkorbel1 linked an issue Apr 28, 2023 that may be closed by this pull request
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for your contribution!

lib/src/values/logic_value.dart Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you for contributing this!

For the future, it's a good idea to check if issues have an assignee already in case someone else is already making progress on it

@mkorbel1 mkorbel1 merged commit 8dc0971 into intel:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement neq
2 participants