Issue#140: Added gt and gte for for consistency to Logic #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
requested changes
Apr 28, 2023
mkorbel1
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
As per #140 , for equality, less than, and less than or equal to, Logic has eq, lt, and lte, respectively, since those operators have different meanings (object equality, conditional assignment, and assignment, respectively). Since greater than and greater than or equal to do not use those operators for something else, they were overloaded for > and >=. However, this is a little inconsistent and confusing to new users. It would be nice if you could also optionally use gt and gte for consistency.
Testing
Added test cases in test/comparison_test.dart
Documentation
Yes. I have updated README.md and doc/tutorials/chapter_2/00_basic_logic.md for the support of gt and gte.