-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
232 add a mechanism for generating random logic values #362
Merged
mkorbel1
merged 46 commits into
intel:main
from
quekyj:232-add-a-mechanism-for-generating-random-logic-values
Jun 7, 2023
Merged
232 add a mechanism for generating random logic values #362
mkorbel1
merged 46 commits into
intel:main
from
quekyj:232-add-a-mechanism-for-generating-random-logic-values
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Max Korbel <max.korbel@intel.com>
mkorbel1
requested changes
May 17, 2023
mkorbel1
requested changes
May 26, 2023
mkorbel1
requested changes
May 31, 2023
mkorbel1
requested changes
Jun 1, 2023
mkorbel1
reviewed
Jun 1, 2023
mkorbel1
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice work!
quekyj
deleted the
232-add-a-mechanism-for-generating-random-logic-values
branch
August 8, 2023 05:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
LogicValue is a useful type since it supports arbitrary width in an efficient representation. For testing purposes, it might be desirable to generate a random value on a bus of arbitrary width. The built-in Dart randomization only randomizes up to 2^32, which means users have to invent their own little code snippets to generate random numbers bigger than 32 bits.
Related Issue(s)
Fix #232
Testing
Add unit test to test random generation of the
LogicValue
.Backwards-compatibility
No
Documentation
Included in the public documentation.