Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#316 Prevent self connecting logic #368

Merged

Conversation

Sanchit-kumar
Copy link
Contributor

@Sanchit-kumar Sanchit-kumar commented May 20, 2023

Description & Motivation

Prevent Logic from connecting to itself #316

Related Issue(s)

#315 (Covered)

Testing

Added testcase to test/bus_test.dart and created an exception lib/src/exceptions/logic/invalid_connection_exception.dart

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Not required.

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

It looks like this is addressing both #315, #316? In what way do you think #315 isn't?

lib/src/exceptions/logic/invalid_connection_exception.dart Outdated Show resolved Hide resolved
lib/src/logic.dart Show resolved Hide resolved
test/bus_test.dart Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the contribution!

@mkorbel1 mkorbel1 merged commit 814fefd into intel:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Logic from connecting to itself Add more informative looped connection error message
2 participants