Fix bug with SSA reuse of signals #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is SSA? |
https://en.wikipedia.org/wiki/Static_single-assignment_form See #344 and #290 for how we got to using it. I am going to write something up about it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
In some cases of logic reuse for SSA, there was a scenario where signals could attempt to reconnect to themselves causing false failures. This PR fixes the bug by skipping over those cases.
This bug was discovered via the integer pipeline multiplier in ROHD-HCL with an updated dependency.
Related Issue(s)
N/A
Testing
Added 2 tests:
Backwards-compatibility
No
Documentation
No