Fixes and improvements related to shifts #412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This PR is primarily focused on making sure shifts (left, right, and right arithmetic) perform without error and correctly for any input. It also includes some additional improvements that are related to fixing this.
LogicValue
by inferring the width (usingofInferWidth
) of positive numberstoInt
on LogicValues with big widths but that can be properly represented by an intRelated Issue(s)
Fix #404
Fix #110
Testing
Extensive new testing for all changes and bug fixes
Backwards-compatibility
No, unless someone was relying on buggy behavior
Documentation
Updated API docs