Fix bug where generated SV has lint issues with plus and shift-left due to SV width expansion #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjayasim9
pushed a commit
to mjayasim9/rohd
that referenced
this pull request
Dec 1, 2023
…ue to SV width expansion (intel#423)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Some operations (
+,<<) can cause the output of the operation to be larger than the inputs. In ROHD, the output width equals the input width (strictly). The generated SV properly did truncation, but in a way that could flag lint errors due to signal width mismatches.This change makes it so that we explicitly slice the relevant range rather than rely on SV behavior for signal width mismatch, thus removing lint issues.
Related Issue(s)
Fix #298
Testing
Added a new test that ensures
+and<<use a slice operation. Don't have an open-source lint tool available for the test suite, but will test it separately to ensure that the fix works properly.Backwards-compatibility
No
Documentation
No