Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update counter example to be simpler and a better reference #448

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

Some feedback about the counter example has been:

  • For newcomers, it is a pretty verbose implementation.
  • The example testbench code doesn't expose newcomers to the await style.

This PR updates the example to use some awaits as well as make the counter implementation simpler. The downside is that it no longer demonstrates Sequential in the more general case, but there are other examples and API docs that can be referenced for that.

Related Issue(s)

N/A

Testing

Example is covered by test, also rerun locally

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Basically just doc update

@mkorbel1 mkorbel1 merged commit 852d48e into intel:main Dec 27, 2023
2 checks passed
@mkorbel1 mkorbel1 deleted the example_update branch December 27, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant