-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/metrics: support mul-res ssim/md5 calculation #24
Conversation
support multi-resolution ssim calculation user should define the case with param "multi_res" as below: multi_res = [(width1, height1, frames1), (width2, height2, frames2), ...] Signed-off-by: Wang Zhanjun <zhanjunx.wang@intel.com>
ecc901d
to
c6a6d1c
Compare
support multi-resolution md5 calculation user should define the case with param "multi_res" as below: multi_res = [(width1, height1, frames1), (width2, height2, frames2), ...] Signed-off-by: Wang Zhanjun <zhanjunx.wang@intel.com>
fad3249
to
b195d94
Compare
can you have a reviw @uartie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we wrote a solution that works with something like this in user config:
"my_test_case_name" : dict(
source = os.path.join(assets, "my_test_case_source.h264"),
reference = os.path.join(assets, "yuv", "my_test_case_ref.yuv"),
format = "I420", frames = 250,
resolution = [
dict(width = 1920, height = 1080, frames = 150),
dict(width = 720, height = 480, frames = 100),
]
),
That is, in user config, we should replace width
and height
keys with a resolution
key that is a list of dict values that can specify one or more width/height for the streams. The sum of frames in the resolution spec should equal the value of frames in outer spec.
Unfortunately, I think ffmpeg always scales the output to a single resolution (and it can't be disabled, afaict). Thus, this patch would break metrics on ffmpeg tests. Maybe it's better to insert the vaapi scaler into the gstreamer decode test pipelines and change ffmpeg decode tests to use the vaapi scaler (instead of sw scaler) so we get the same behavior and a single output resolution across all middleware decode tests. |
I keep the |
I think that this is a ffmpeg enhancement issue, we should create an issue against ffmpeg. Of cause, we also can add "videoscale ! video/x-raw,width={width},height={height}" to the gstreamer at now. |
Well, yes, of course, those would have to be updated with such a change. What's wrong with that? |
Yes, but we don't break existing tests intentionally either. Let's settle on adding vaapi output scaling (not sw scaling) to the ffmpeg and gstreamer decode test pipelines for now. Pure multi-res support has a long way to go before I would be willing to accept such a change here. |
support multi-resolution ssim/md5 calculation
user should define the case with param "multi_res" as below:
multi_res = [(width1, height1, frames1), (width2, height2, frames2), ...]
Signed-off-by: Wang Zhanjun zhanjunx.wang@intel.com