Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a compiler warning instead of error when built with just avx512f #147

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Throw a compiler warning instead of error when built with just avx512f #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2240608
Throw a compiler warning instead of error when built with avx512f
r-devulap Apr 26, 2024
c5050d1
lint fix
r-devulap Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/x86simdsort-static-incl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,11 @@ x86simdsortStatic::keyvalue_qsort(T1 *key, T2 *val, size_t size, bool hasnan)
avx512_qsort_kv(key, val, size, hasnan);
}

#elif defined(__AVX512F__)
#error "x86simdsort requires AVX512DQ and AVX512VL to be enabled in addition to AVX512F to use AVX512"

#elif defined(__AVX2__) && !defined(__AVX512F__)
#elif defined(__AVX2__)
#if defined(__AVX512F__)
#warning \
"Building x86simdsortStatic with AVX2 sort functions. AVX512 sorting additionally requires AVX512DQ and AVX512VL."
#endif
/* 32-bit and 64-bit dtypes vector definitions on AVX2 */
#include "avx2-32bit-half.hpp"
#include "avx2-32bit-qsort.hpp"
Expand Down
Loading