Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the tag service object with unit tests #34

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Adding the tag service object with unit tests #34

merged 1 commit into from
Jul 14, 2022

Conversation

fear-the-reaper
Copy link
Contributor

Description

Added `tag.go` and `tagService_test.go`

Issues

add the related issue(s) your change tackles
#16

Type of change

list down the type of change

  • Bug fix
  • New feature (added a new endpoint or created)
  • Breaking fix (a bug fix or new feature that would cause exisiting functionality not to work as expected)

Checklist

  • if a new feature was added it passed all its (if made) test cases
  • if a bug fix was added it passed all its existing test cases

Important Rules

  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review

Please delete if the PR is for bug fixing.

@fear-the-reaper fear-the-reaper added the GSoC Issues that can be worked on before/during GSoC-2022 label Jul 14, 2022
@sp35 sp35 merged commit 0336028 into main Jul 14, 2022
@sp35 sp35 deleted the tag-service-objects branch July 14, 2022 11:51
@fear-the-reaper fear-the-reaper mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sp35 sp35 sp35 approved these changes

@eshaan7 eshaan7 Awaiting requested review from eshaan7

Assignees
No one assigned
Labels
GSoC Issues that can be worked on before/during GSoC-2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fear-the-reaper @sp35