This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Fix for issue #27: smart plugin returns error if nothing is collected #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @intelsdi-x/plugin-maintainers Could you please review and merge |
| @@ -279,7 +279,7 @@ func TestCollectMetrics(t *testing.T) { | |||
|
|
|||
| ReadSmartData = func(device string, | |||
| sysutilProvider SysutilProvider) (*SmartValues, error) { | |||
| return &SmartValues{}, nil | |||
| return nil, errors.New("x not valid disk") | |||
There was a problem hiding this comment.
why is it error out all the time?
There was a problem hiding this comment.
In fact as the next snippet was removed in a previous commit, I had to adapt the code so that the tests pass
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject says it all
will wait for TravisCI to run tests before potentially submitting new revision as tests execution is system dependant