Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Fix tests in master, upgrade all dependencies in prep for v2.0. #21

Merged
merged 3 commits into from
Mar 20, 2017

Conversation

nathankleyn
Copy link
Contributor

@nathankleyn nathankleyn commented Mar 19, 2017

This fixes #19, and gets us one step closer to cutting the v2.0 release
because we are now working on Redis v3.0+, which fixes #20.

@nathankleyn
Copy link
Contributor Author

(Pinging @maciekciolek who will want this fix to use Icicle on Redis >= 3.0. 😀 )

organization := "com.intenthq.icicle",
version := appVersion,
publishMavenStyle := true,
crossPaths := false,
autoScalaLibrary := false,
publishArtifact in Test := false,
pomIncludeRepository := { _ => false },
resolvers += "Scalaz Bintray Repo" at "https://dl.bintray.com/scalaz/releases",
// resolvers += "Scalaz Bintray Repo" at "https://dl.bintray.com/scalaz/releases",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove this, was a test and forgot to take it out!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! 👍

This fixes #19, and gets us one step closer to custting the v2.0 release
because we are now fixed on Redis v3.0+, which fixes #20.
@nathankleyn nathankleyn force-pushed the 19-20-fix-builds-upgrade-deps branch 2 times, most recently from acc0233 to eb86f53 Compare March 20, 2017 12:08
@nathankleyn nathankleyn force-pushed the 19-20-fix-builds-upgrade-deps branch from eb86f53 to 3008e69 Compare March 20, 2017 12:11
Copy link
Member

@albertpastrana albertpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertpastrana albertpastrana merged commit ca308d5 into master Mar 20, 2017
@albertpastrana albertpastrana deleted the 19-20-fix-builds-upgrade-deps branch March 20, 2017 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icicle does not work on Redis >= 3.0 Master build is failing
2 participants