This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Fix tests in master, upgrade all dependencies in prep for v2.0. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Pinging @maciekciolek who will want this fix to use Icicle on Redis >= 3.0. 😀 ) |
nathankleyn
force-pushed
the
19-20-fix-builds-upgrade-deps
branch
from
March 19, 2017 22:18
cf79902
to
f5627a9
Compare
nathankleyn
commented
Mar 20, 2017
project/commons.scala
Outdated
organization := "com.intenthq.icicle", | ||
version := appVersion, | ||
publishMavenStyle := true, | ||
crossPaths := false, | ||
autoScalaLibrary := false, | ||
publishArtifact in Test := false, | ||
pomIncludeRepository := { _ => false }, | ||
resolvers += "Scalaz Bintray Repo" at "https://dl.bintray.com/scalaz/releases", | ||
// resolvers += "Scalaz Bintray Repo" at "https://dl.bintray.com/scalaz/releases", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove this, was a test and forgot to take it out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! 👍
nathankleyn
force-pushed
the
19-20-fix-builds-upgrade-deps
branch
2 times, most recently
from
March 20, 2017 12:08
acc0233
to
eb86f53
Compare
nathankleyn
force-pushed
the
19-20-fix-builds-upgrade-deps
branch
from
March 20, 2017 12:11
eb86f53
to
3008e69
Compare
albertpastrana
approved these changes
Mar 20, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #19, and gets us one step closer to cutting the v2.0 release
because we are now working on Redis v3.0+, which fixes #20.