Websocket codes #1403
Merged
Websocket codes #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertUnruh
reviewed
May 14, 2023
Co-authored-by: AlbertUnruh <73029826+AlbertUnruh@users.noreply.github.com> Signed-off-by: LordOfPolls <dev@lordofpolls.com>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## unstable #1403 +/- ##
============================================
- Coverage 60.32% 60.32% -0.01%
============================================
Files 139 139
Lines 14633 14638 +5
============================================
+ Hits 8828 8830 +2
- Misses 5805 5808 +3
☔ View full report in Codecov by Sentry. |
AlbertUnruh
reviewed
May 14, 2023
|
besides my suggestions it looks good to me, but I won't approve it since I don't know the codes and whether they are correct or not |
Co-authored-by: AlbertUnruh <73029826+AlbertUnruh@users.noreply.github.com> Signed-off-by: LordOfPolls <dev@lordofpolls.com>
|
Merging without approval due to importance of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Creating on behalf of @zevaryx.
This PR marks additional gateway close codes as recoverable/resumable.
to be clear
If your bot is online 24/7 you need a process manager like docker, systemd or whatever. Do NOT rely on the library to automatically restart itself. The library certainly tries to recover, but the internet is a scary place
Changes
Related Issues
Test Scenarios
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files