Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with cellxgene-1.0.0 #64

Closed

Conversation

michaeleekk
Copy link

Didn't test a lot but it seems to be able to build and click some buttons in the UI.

One thing I'm not so sure is the data adaptor changes. It was able to use with in the past but I got an error about __enter__. I guess either there are something changed or I used the wrong data adaptor.

Feel free to edit the PR or let me know so that I could make the PR better.

@michaeleekk michaeleekk mentioned this pull request Dec 2, 2021
@z5ouyang
Copy link
Collaborator

z5ouyang commented Dec 7, 2021

Thanks for the PR. I will check and make modifications for cellxgene v1.
several points I found:

  1. config: The cellxgene requirement file is moved under server folder.
  2. appConfig.is_multi_dataset() was used for "--dataroot" to host several datasets in a folder, instead of one port for a dataset. This enabled CellDepot to host many datasets. Thus it is required, I will try to find a solution for this.

@z5ouyang z5ouyang closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants