fix-root-urls #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This has broken assumptions around automatically downloading schemas.
jkakar
added a commit
that referenced
this pull request
Jan 30, 2014
- APIs that are mounted with a prefix URL, like `http://example.com/api`, now work correctly. - I've left a failing test in place. The `Heroics.cli_from_schema_url` and `Heroics.client_from_schema_url` methods are a bit problematic with URL prefixes. I'm going to go ahead and land this to unblock Mark McGranaghan.
|
Thanks! On Thu, Jan 30, 2014 at 1:50 PM, Jamu Kakar notifications@github.comwrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://example.com/api,now work correctly.
Heroics.cli_from_schema_urland
Heroics.client_from_schema_urlmethods are a bit problematicwith URL prefixes.
I'm going to go ahead and land this to unblock Mark McGranaghan.