Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Resolve empty successful deletes #2

Merged
merged 1 commit into from
Oct 8, 2015
Merged

Resolve empty successful deletes #2

merged 1 commit into from
Oct 8, 2015

Conversation

bobjflong
Copy link

No description provided.

};
Ember.run(function() {
adapter._handleRejections("DELETE", {status: 200}, resolve, Ember.$.noop);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth adding a test for the rejection case, ie different HTTP verb, status code other than 200.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@paddyobrien
Copy link

👍

bobjflong added a commit that referenced this pull request Oct 8, 2015
Resolve empty successful deletes
@bobjflong bobjflong merged commit d168260 into intercom:master Oct 8, 2015
@bobjflong bobjflong deleted the BL/deleteresolve branch October 8, 2015 12:12
@bobjflong bobjflong restored the BL/deleteresolve branch October 8, 2015 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants