Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-target and updated nuget packages #147

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

jpasichnyk
Copy link
Contributor

Why?

The current package isn't targeted against "net452" which many people are still using. This change to multi-target the library will allow many users currently stuck on the 1.0.x branch to use the latest version of the SDK.

How?

  • Added net452 as a second target framework in the .csproj files
  • Updated referenced NuGet packages

@markive markive mentioned this pull request Jan 25, 2019
@markalanevans
Copy link

So if you are using 4.6.1 what happens?

@lindeberg
Copy link

Merge?

@Bumbolio
Copy link

Bumbolio commented Jul 3, 2019

Would love to see this merged and published to nuget as an official build. I have a large project running net452 and it would be great to use the latest build.

@jonnyom
Copy link
Contributor

jonnyom commented Jul 25, 2019

Hey folks, sorry for the delay on this.

We're good to merge this and we'll work on getting it published to Nuget ASAP

@jonnyom jonnyom merged commit a9993b3 into intercom:master Jul 25, 2019
@minhhieugma
Copy link

why do you not have .net core library? it is terrible!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants