Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no email in creating contact params #310

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

hypeofpipe
Copy link
Contributor

@hypeofpipe hypeofpipe commented Feb 10, 2022

Why?

To make it possible to create Contact either with external_id or email

Closes #308
Closes #309

How?

  • Add email param to createUser
  • Fix test

@hypeofpipe hypeofpipe self-assigned this Feb 10, 2022
johnnynader
johnnynader previously approved these changes Feb 10, 2022
@@ -7,7 +7,6 @@
"target": "es5",
"module": "commonjs",
"moduleResolution": "node",
"importHelpers": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing this line, we revert the value of importHelpers to default one - false

So what's the difference?

Importing helpers results in using ts-lib for different functions, such as exportingStar. By disabling importHelpers we force TS to generate JS code, instead of requiring ts-lib:

importHelpers: true:

(0, tslib_1.__exportStar)(require("./admin/admin.types"), exports);
(0, tslib_1.__exportStar)(require("./article/article.types"), exports);
(0, tslib_1.__exportStar)(require("./common/common.types"), exports);
(0, tslib_1.__exportStar)(require("./company/company.types"), exports);

importHelpers: false:

var __exportStar = (this && this.__exportStar) || function(m, exports) {
    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
};

@hypeofpipe hypeofpipe merged commit a2a59d0 into master Feb 10, 2022
@johnnynader johnnynader deleted the fix/no-email-in-create-contact branch February 15, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing a conversation results in a BadResponse from Intercom tslib is missing as a dependency
2 participants