Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds access to api_base configuration option #329

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Conversation

lloydliyu
Copy link
Contributor

Why?

Recently an api_base option was added to the Messenger for certain scenarios where the default ping url can't be used.

How?

Adds it as an allowed configuration option.

Copy link

@arindambarman1-zz arindambarman1-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lloydliyu lloydliyu merged commit 1ee1fc5 into master Oct 7, 2020
@lloydliyu lloydliyu deleted the dan.c/add_api_base branch October 7, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants