Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ESLint v4 #57

Closed
ryym opened this issue Jun 12, 2017 · 6 comments
Closed

Migrate to ESLint v4 #57

ryym opened this issue Jun 12, 2017 · 6 comments
Assignees
@ybiquitous

Comments

@ryym
Copy link
Contributor

ryym commented Jun 12, 2017 •
edited
Loading

http://eslint.org/docs/4.0.0/user-guide/migrating-to-4.0.0

依存しているプラグインが対応するのを待つ必要がある。
@ybiquitous
Copy link
Contributor

eslint-config-airbnb のこの issue 👇 が解決されれば、着手可能かも。
airbnb/javascript#1447

@ybiquitous
Copy link
Contributor

更新来ました〜

@ybiquitous ybiquitous self-assigned this Aug 1, 2017
@ybiquitous
Copy link
Contributor

Warnings:

can't resolve reference #/definitions/basicConfig from id #
can't resolve reference #/definitions/basicConfigOrBoolean from id #
can't resolve reference #/definitions/basicConfigOrBoolean from id #

The fixed version of eslint-plugin-react is not yet released 😞

@ybiquitous ybiquitous removed their assignment Aug 1, 2017
@ybiquitous ybiquitous self-assigned this Aug 23, 2017
@ybiquitous ybiquitous mentioned this issue Aug 23, 2017
Merged
@ybiquitous
Copy link
Contributor

Fixed via #82

@ybiquitous
Copy link
Contributor

@interfirm/dev
ESLint v4 に対応しました！
各プロジェクトの package.json で "eslint": "3" と固定している場合は、バージョン 🆙 できますのでよろしくお願いします 🙇

@ryym
Copy link
Contributor Author

ryym commented Aug 23, 2017

@ybiquitous ありがとうございます 🎉

oandregal added a commit to Automattic/eslint-eslines that referenced this issue Sep 8, 2017
@oandregal
Disregard any ESLint stderr to calculate exit code
a0cf437 
Since the goal of eslines is to downgrade errors on non-modified lines,
we can't count on eslint's exit code. Previously, we assumed that if
eslint outputs something on its stderr, this means it encountered some
other error. It turned out to be a bad assumption, as the following
example illustrates.

Currently, the eslint-plugin-react outputs some warning in the stderr
channel interfirm/eslint-config-interfirm#57
ESLint will output that errors in the stderr but if it doesn't find any
lint issues it will report zero as its exit code. In our case,
although eslines will exit 0 as well, we'd return 1 because
we heard ESLint reported something in the stderr channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ybiquitous ybiquitous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ybiquitous @interfirm-master @ryym