Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate benchmarking imports from frame_support::benchmarking to frame_benchmarking::v2 #954

Closed
daniel-savu opened this issue Mar 1, 2023 · 1 comment · Fixed by #1093
Labels
enhancement New feature or request prio:high

Comments

@daniel-savu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Imports from frame_support::benchmarking have been deprecated in polkadot-0.9.38, however this is not yet a breaking change.

Describe the solution you'd like
To avoid our benchmarks from breaking in the future, update imports and any syntax as described in the PR.

Describe alternatives you've considered
Could also wait until this becomes a breaking change.

@daniel-savu daniel-savu added enhancement New feature or request prio:high labels Mar 1, 2023
@nud3l nud3l added this to Backlog Mar 1, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Mar 1, 2023
@nud3l nud3l moved this from New 🆕 to Todo ⏳ in Backlog Mar 6, 2023
@gregdhill
Copy link
Member

This is mostly done, see #1043. We also did not yet update collator-selection to v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:high
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants