[BREAKING] add Routes schema; remove Transfer.type #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "destination_ledger": {"$ref": "Iri.json"}, | ||
| "connector": {"$ref": "Iri.json"}, | ||
| "min_message_window": {"type": "number", "minimum": 0, "description": "seconds"}, | ||
| "source_account": {"$ref": "Iri.json"}, |
There was a problem hiding this comment.
Might be helpful to add descriptions to these properties so it's clear what they're for
sentientwaffle
force-pushed
the
feature/dj-destination-routing
branch
from
0ab4325
to
248ccc0
Compare
|
Ok, added some descriptions. |
| "items": {"type": "number"}, | ||
| "description": "[source_amount, destination_amount]" | ||
| }, | ||
| "description": "a list of points" |
There was a problem hiding this comment.
Could this be expanded a bit?
|
LGTM |
sentientwaffle
force-pushed
the
feature/dj-destination-routing
branch
from
248ccc0
to
5472f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.