fix(packet): add precheck for timestamps in Prepares #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
reviewed
Apr 15, 2021
koivunej
approved these changes
Apr 15, 2021
whalelephant
force-pushed
the
whalelephant
branch
2 times, most recently
from
2a89cc4
to
5e5c8c1
Compare
…rono Signed-off-by: bwty <whalelephant@users.noreply.github.com> test: datetime ensure error with invalid characters Signed-off-by: bwty <whalelephant@users.noreply.github.com> doc: Prepare package datetime spec Signed-off-by: bwty <whalelephant@users.noreply.github.com> Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
whalelephant
force-pushed
the
whalelephant
branch
from
bb3c289
to
a47ac32
Compare
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
whalelephant
force-pushed
the
whalelephant
branch
from
a47ac32
to
b0e9b99
Compare
koivunej
changed the title
|
This is a correctness update which will deny some patterns which were previously accepted as valid timestamps, but did not adhere to RFC and the asn1 specification. The previously accepted timestamps can be seen with the test case. Merging slightly ahead of the 24h window. |
Mirko-von-Leipzig
pushed a commit
to Mirko-von-Leipzig/interledger-rs
that referenced
this pull request
Aug 3, 2021
this follows from finding a case where the parsed timestamp doesn't match the output timestamp, even with the fix made in interledger#707. the strict feature is included in the "rountrip-only". Signed-off-by: Joonas Koivunen <joonas.koivunen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc: #705
Check if bytes are numerical values before handing to chrono