disallow extra trailing bytes in Fulfillment packet #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelephant
force-pushed
the
whalelephant
branch
from
75238d7
to
c33d698
Compare
koivunej
reviewed
Apr 27, 2021
koivunej
reviewed
Apr 27, 2021
koivunej
reviewed
Apr 27, 2021
whalelephant
force-pushed
the
whalelephant
branch
from
c33d698
to
9d42525
Compare
koivunej
reviewed
Apr 27, 2021
whalelephant
force-pushed
the
whalelephant
branch
from
b7656c0
to
211d8bf
Compare
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>
whalelephant
force-pushed
the
whalelephant
branch
from
211d8bf
to
3581152
Compare
koivunej
reviewed
Apr 28, 2021
Co-authored-by: Joonas Koivunen <joonas.koivunen@gmail.com>
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: #705
Trailing bytes with length included in the varlen octet string that do not contribute to the data field should not be allowed.