New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: Allow fuzzing for Unknown Data (ErrorCode and FrameType) #719

Merged

koivunej merged 8 commits into interledger:master from whalelephant:stream-fuzz-unknown-data

May 6, 2021

Contributor

whalelephant commented May 5, 2021

cc: #705

This PR addresses:

ensures no inner trailing bytes in frame data
adds roundtrip-only feature for fuzzing in the case of saturated value replacement
stores and return Unknown ErrorCode and FrameTypes

whalelephant requested a review from emschwartz as a code owner

May 5, 2021 14:11

Collaborator

koivunej commented May 5, 2021

Could you add a similar test run for the roundtrip-only below this: https://github.com/interledger-rs/interledger-rs/blob/f054cad6beb12c5d4bf83c5456fbfb2e28c61f65/.github/workflows/ci.yml#L70

koivunej reviewed

View reviewed changes

crates/interledger-stream/src/packet.rs Show resolved Hide resolved

koivunej reviewed

View reviewed changes

crates/interledger-stream/src/packet.rs Outdated Show resolved Hide resolved

koivunej reviewed

View reviewed changes

crates/interledger-stream/src/packet.rs Outdated Show resolved Hide resolved

koivunej reviewed

View reviewed changes

crates/interledger-stream/src/packet.rs Outdated Show resolved Hide resolved

koivunej reviewed

View reviewed changes

crates/interledger-stream/src/packet.rs Outdated Show resolved Hide resolved

koivunej approved these changes

View reviewed changes

Collaborator

koivunej left a comment

I think this is very much looking good to go with the few suggestions I added, and the workflow additions.

koivunej reviewed

View reviewed changes

crates/interledger-stream/src/packet.rs Outdated Show resolved Hide resolved

whalelephant and others added 8 commits

May 6, 2021 14:54


          feat: add check for frame data length

f3d000e

Signed-off-by: bwty <whalelephant@users.noreply.github.com>


          feat: store interledger-stream::packet::ErrorCode::Unknown(val)

937e10c

Signed-off-by: bwty <whalelephant@users.noreply.github.com>


          feat: return error to stop fuzzing roundtrip for varuint>u64::MAX

83d1a7c

Signed-off-by: bwty <whalelephant@users.noreply.github.com>


          feat: store Unknown FrameTypes raw data in StreamPackets

ebed693

Signed-off-by: bwty <whalelephant@users.noreply.github.com>


          test: serialize and deserialize unknown frame type data

eb3da9f

Signed-off-by: bwty <whalelephant@users.noreply.github.com>


          fix: use naming inner trailing bytes

cb6fad2

Signed-off-by: bwty <whalelephant@users.noreply.github.com>


          fixes: apply fixes from PR

711f492

Co-authored-by: Joonas Koivunen <joonas.koivunen@gmail.com>
Signed-off-by: bwty <whalelephant@users.noreply.github.com>


          chore: add roundtrip-only feat to CI tests

1f3c21f

Signed-off-by: bwty <whalelephant@users.noreply.github.com>

whalelephant force-pushed the stream-fuzz-unknown-data branch from 8679806 to 1f3c21f Compare

May 6, 2021 07:54

koivunej changed the title ~~Allow fuzzing for Unknown Data (ErrorCode and FrameType)~~ stream: Allow fuzzing for Unknown Data (ErrorCode and FrameType)

Collaborator

koivunej commented May 6, 2021

Going ahead of merge slightly ahead of 24h as this only changes the feature = "strict" and adds the feature = "roundtrip-only" functionality.

koivunej merged commit 2edc013 into interledger:master

This was referenced May 6, 2021

Continued fuzzing and hardening #705

Open

Tracking breaking changes #668

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment