docs: replace payment pointer with wallet address #1951

njlie · 2023-09-21T13:13:10Z

Changes proposed in this pull request

Replaces all instances of 'payment pointer' with 'wallet address in docs that live on Rafiki's Github.

Context

Checklist

BlairCurrey · 2023-09-22T09:23:31Z

README.md

@@ -15,7 +15,7 @@ This includes

 Rafiki is made up of several components including an Interledger connector, a high-throughput accounting database called [TigerBeetle](https://rafiki.dev/concepts/accounting/tigerbeetle/), and several APIs:

- the [Admin API](https://rafiki.dev/apis/backend/schema/) to create [peering relationships](https://rafiki.dev/concepts/interledger-protocol/peering/), add supported [assets](https://rafiki.dev/concepts/asset/), and issue [payment pointers](https://rafiki.dev/reference/glossary/#payment-pointer)
+- the [Admin API](https://rafiki.dev/apis/backend/schema/) to create [peering relationships](https://rafiki.dev/concepts/interledger-protocol/peering/), add supported [assets](https://rafiki.dev/concepts/asset/), and issue [wallet addresses](https://rafiki.dev/reference/glossary/#payment-pointer)


does the article/url need to be renamed here? https://rafiki.dev/reference/glossary/#payment-pointer

I guess /reference/glossary#payment-pointer is referenced many places, not just here.

BlairCurrey

I think this was missed because of the newline char:

rafiki/localenv/docs/peer-setup.md

Lines 355 to 356 in 2dac9e5

    
           On the [primary instance](http://localhost:3001) execute the following command to create a payment 
        
           pointer ID:

njlie · 2023-09-27T21:28:59Z

I think this was missed because of the newline char:

rafiki/localenv/docs/peer-setup.md

Lines 355 to 356 in 2dac9e5

On the [primary instance](http://localhost:3001) execute the following command to create a payment

pointer ID:

Good catch @BlairCurrey!

mkurapov · 2023-09-28T16:41:16Z

packages/documentation/src/content/docs/integration/getting-started.md

@@ -230,11 +230,11 @@ Example Successful Response
 ```
 {
  "data": {
-    "createPaymentPointer": {
+    "createWalletAddress": {


Will this be a new mutation or removing the old one?

This should be a new mutation, in https://github.com/interledger/rafiki/tree/nl-rename-all-payment-pointer the createPaymentPointer mutation will be refactored to createWalletAddress.

mkurapov · 2023-09-28T16:41:25Z

packages/documentation/src/content/docs/integration/getting-started.md

@@ -135,9 +135,9 @@ The Rafiki `backend` exposes the [Open Payments](/reference/glossary#open-paymen

 The Open Payments Auth Server requires integration with an Identity Provider to handle user authentication and consent. For more information on how to integrate an Identity Provider with the reference implementation of the Open Payments Auth Server, see the docs in the `auth` package.

-## Issuing Payment Pointers
+## Issuing s


Suggested change

## Issuing s

## Issuing Wallet Addresses

mkurapov · 2023-09-28T16:41:54Z

packages/documentation/src/content/docs/integration/getting-started.md

+| `wallet_address.not_found`        | A requested wallet address was not found                                    |
+| `wallet_address.web_monetization` | Web Monetization payments received via STREAM.                              |


same thing as 👇 , are we renaming the existing webhooks or just adding new ones, and deprecating the payment pointer ones?

Same deal, https://github.com/interledger/rafiki/tree/nl-rename-all-payment-pointer should rename the existing ones. This PR will just handle docs changes. Though I see now that Web Monetization may not make sense for a wallet address with a non-ILP payment method.

mkurapov

This is the classic "LGTM" comment

LGTM (minus one small thing)

mkurapov · 2023-10-12T21:24:47Z

packages/token-introspection/src/openapi/token-introspection.yaml

@@ -95,13 +95,13 @@ components:
          title: client
          type: string
          description: |-
-            Payment pointer of the client instance that is making this request.
+            Wallet address of the client instance that is making this request.


we should generate the typescript types from the api spec

…rafiki backend

sabineschaller

I think this is good to go now :-)

* feat(backend): rename "payment pointer" tables & columns to use "wallet address" (#1937) Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local> * feat(backend, mock-ase): rename payment pointer to wallet address in rafiki code (#2029) * fix(backend): rename paymentPointerId column in combinedPaymentsView to walletAddressId (#2043) * docs: replace payment pointer with wallet address (#1951) * feat(backend): remove connections route (#1940) (#2051) Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev> * feat(backend): unauthenticated get incoming payment (#1952) (#2052) Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev> Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com> * feat(auth): fix auth tests for access tokens (#2053) * feat(backend): remove payment pointer from url, retrieve it from request query or body (#2042) * refactor(backend): swap connection for methods (#2054) Co-authored-by: Nathan Lie <lie4nathan@gmail.com> * fix(backend): resolve breaking build after main rebase (#2085) * fix(backend): combined_payment, ilp service tests (#2094) * fix(backend): combined_payment, ilp service tests * chore(backend): format * fix(backend): bad test refactor * fix(postman): invalid json (#2096) * fix: fetch walletAddress graph in quote and outgoing payment service (#2099) * fix(postman): env var usage (#2107) * feat(backend): add quotes route to exceptions in wallet address middleware (#2108) * chore: formatting * fix(backend): fix GET /incoming-payments (#2111) * fix(backend): remove wallet address from OP response id and fix receiver service (#2115) * fix: remove wallet address from op resource urls * feat: return auth server url in public incoming payment and fix receiver service * fix: quote issue * fix: walletAddress middleware * chore: update postman * fix: listing * chore: remove console.log * fix: progress towards making listing work * fix(backend): fix create remote incoming payment (#2121) * fix(postman): misc postman fixes * fix(postman): complete incoming payment (#2126) * fix: file name correction (#2127) * fix: GET resource lists, use op client (#2122) * fix(postman): update list urls * fix(openapi): rm defaults for first, last * refactor(postman): query param order for readability * fix(backend): update to new open-payments pkgs * fix(backend): use op client to get authServer * fix(backend): rm old code * fix(backend): receiver tests * chore: cleanup * feat: make list query parameter configurable * chore: update OP package and fix types --------- Co-authored-by: Sabine Schaller <sabine@interledger.org> * fix(postman): additional fixes * fix: wallet address on the fly creation (#2129) * chore: update postman environments * Postman: update description for P2P example * Postman: Remove finalizationReason from getGrants API + fix createWalletAddress * chore: bump open-payments package in auth * chore: update last few remaining mentions of payment pointers * chore(postman): remove references to payment pointer * chore: update another reference to pp --------- Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local> Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev> Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com> Co-authored-by: Sabine Schaller <sabine@interledger.org> Co-authored-by: Sarah Jones <sarah38186@gmail.com> Co-authored-by: Max Kurapov <maxkurapov@gmail.com> Co-authored-by: Max Kurapov <max@interledger.org>

github-actions bot added type: localenv Local playground pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation labels Sep 21, 2023

njlie requested review from BlairCurrey, mkurapov and sabineschaller September 21, 2023 13:13

njlie force-pushed the nl-docs-replace-pp branch from d53ddfc to 28e1a48 Compare September 21, 2023 14:08

njlie requested review from momerath42 and omertoast and removed request for momerath42 September 22, 2023 08:13

BlairCurrey reviewed Sep 22, 2023

View reviewed changes

github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase labels Sep 27, 2023

njlie force-pushed the nl-docs-replace-pp branch from d793eda to 8b37abb Compare September 27, 2023 21:49

njlie requested a review from BlairCurrey September 27, 2023 21:49

github-actions bot removed type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase labels Sep 27, 2023

mkurapov reviewed Sep 28, 2023

View reviewed changes

njlie force-pushed the nl-docs-replace-pp branch from e0f42c3 to cb62cf6 Compare September 28, 2023 17:30

njlie force-pushed the nl-rename-all-payment-pointer branch from e4345c1 to da5964f Compare September 28, 2023 22:20

njlie force-pushed the nl-docs-replace-pp branch from cb62cf6 to e0c4004 Compare September 28, 2023 22:24

BlairCurrey approved these changes Oct 2, 2023

View reviewed changes

github-actions bot added pkg: auth Changes in the GNAP auth package. pkg: mock-ase labels Oct 11, 2023

njlie requested a review from mkurapov October 11, 2023 21:16

mkurapov approved these changes Oct 12, 2023

View reviewed changes

njlie force-pushed the nl-rename-all-payment-pointer branch from cc37144 to 5804314 Compare October 12, 2023 22:17

mkurapov mentioned this pull request Oct 13, 2023

feat(backend, mock-ase): rename payment pointer to wallet address in rafiki code #2029

Merged

5 tasks

Base automatically changed from nl-rename-all-payment-pointer to nl-open-payments-updates October 17, 2023 15:47

Nathan Lie and others added 8 commits October 17, 2023 14:47

feat(backend, mock-ase): rename payment pointer to wallet address in …

bdef387

…rafiki backend

feat: more replacements in other packages

7b712ac

docs: replace in localenv docs

fa431de

docs: fix typos

67e2c0b

docs: update rafiki.dev urls

5cdb0e2

docs: fix header typo

480ef8a

feat: rename/drop indices & constraints

705c2b7

docs: remove another instance of 'payment pointer'

6d8ab9e

njlie force-pushed the nl-docs-replace-pp branch from 1cd9d00 to 6d8ab9e Compare October 17, 2023 22:07

sabineschaller approved these changes Oct 18, 2023

View reviewed changes

njlie mentioned this pull request Oct 18, 2023

Rename payment pointer -> wallet address #1893

Closed

2 tasks

njlie merged commit cbe70ae into nl-open-payments-updates Oct 18, 2023
11 of 16 checks passed

njlie deleted the nl-docs-replace-pp branch October 18, 2023 15:02

njlie added a commit that referenced this pull request Oct 23, 2023

docs: replace payment pointer with wallet address (#1951)

09a3294

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: replace payment pointer with wallet address #1951

docs: replace payment pointer with wallet address #1951

njlie commented Sep 21, 2023 •

edited

Loading

BlairCurrey Sep 22, 2023

BlairCurrey Sep 22, 2023

BlairCurrey left a comment •

edited

Loading

njlie commented Sep 27, 2023

mkurapov Sep 28, 2023

njlie Sep 28, 2023

mkurapov Sep 28, 2023

mkurapov Sep 28, 2023

njlie Sep 28, 2023 •

edited

Loading

mkurapov left a comment •

edited

Loading

mkurapov Oct 12, 2023

sabineschaller left a comment

	On the [primary instance](http://localhost:3001) execute the following command to create a payment
	pointer ID:

		\| `wallet_address.not_found` \| A requested wallet address was not found \|
		\| `wallet_address.web_monetization` \| Web Monetization payments received via STREAM. \|

docs: replace payment pointer with wallet address #1951

docs: replace payment pointer with wallet address #1951

Conversation

njlie commented Sep 21, 2023 • edited Loading

Changes proposed in this pull request

Context

Checklist

BlairCurrey Sep 22, 2023

Choose a reason for hiding this comment

BlairCurrey Sep 22, 2023

Choose a reason for hiding this comment

BlairCurrey left a comment • edited Loading

Choose a reason for hiding this comment

njlie commented Sep 27, 2023

mkurapov Sep 28, 2023

Choose a reason for hiding this comment

njlie Sep 28, 2023

Choose a reason for hiding this comment

mkurapov Sep 28, 2023

Choose a reason for hiding this comment

mkurapov Sep 28, 2023

Choose a reason for hiding this comment

njlie Sep 28, 2023 • edited Loading

Choose a reason for hiding this comment

mkurapov left a comment • edited Loading

Choose a reason for hiding this comment

mkurapov Oct 12, 2023

Choose a reason for hiding this comment

sabineschaller left a comment

Choose a reason for hiding this comment

njlie commented Sep 21, 2023 •

edited

Loading

BlairCurrey left a comment •

edited

Loading

njlie Sep 28, 2023 •

edited

Loading

mkurapov left a comment •

edited

Loading