feat(api): cancel outgoing payment #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
golobitch
changed the title
golobitch
force-pushed
the
feature/2688-add-canceloutgoingpayment-graphql-api
branch
from
2989e03
to
4920165
Compare
github-actions
bot
added
pkg: documentation
golobitch
force-pushed
the
feature/2688-add-canceloutgoingpayment-graphql-api
branch
from
09adfdb
to
57c6f8b
Compare
golobitch
force-pushed
the
feature/2688-add-canceloutgoingpayment-graphql-api
branch
from
57c6f8b
to
1093442
Compare
mkurapov
reviewed
May 3, 2024
localenv/mock-account-servicing-entity/app/lib/webhooks.server.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/open_payments/payment/outgoing/service.test.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/graphql/resolvers/outgoing_payment.test.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/integration/event-handlers.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/integration/event-handlers.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Kurapov <max@interledger.org>
Co-authored-by: Max Kurapov <max@interledger.org>
golobitch
force-pushed
the
feature/2688-add-canceloutgoingpayment-graphql-api
branch
from
4f1368a
to
7c9f5c0
Compare
mkurapov
reviewed
May 6, 2024
packages/backend/src/graphql/resolvers/outgoing_payment.test.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/open_payments/payment/outgoing/service.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Kurapov <max@interledger.org>
Co-authored-by: Max Kurapov <max@interledger.org>
…metadata Co-authored-by: Max Kurapov <max@interledger.org>
golobitch
force-pushed
the
feature/2688-add-canceloutgoingpayment-graphql-api
branch
from
f5e243f
to
0d1b4dd
Compare
mkurapov
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Add an API for canceling outgoing payment. This can be possible only if outgoing payment is in funding state. Normally, this API would be called by ASE to cancel the outgoing payment. It can be canceled due too numerous reasons like account not having enough balance or like his KYC is not valid, etc. ASE can also specify cancelation reason, and it will be written in meta under cancellationReason key.
Context
fixes #2688
Checklist
fixes #number